Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ecies #4

Merged
merged 4 commits into from
Oct 11, 2024
Merged

feat: ecies #4

merged 4 commits into from
Oct 11, 2024

Conversation

Nesopie
Copy link
Contributor

@Nesopie Nesopie commented Sep 17, 2024

No description provided.

@chiro-hiro
Copy link

chiro-hiro commented Sep 18, 2024

Hi @Nesopie n

Can you provide a sequence diagram?, It will help to explain your idea and make the protocol more understandable.

@Nesopie
Copy link
Contributor Author

Nesopie commented Sep 18, 2024

Hi @chiro-hiro !
We've added some more diagrams

@amiabix
Copy link
Collaborator

amiabix commented Sep 23, 2024

@Nesopie Thankyou for adding it, Let me ask the team to have a view

@chiro-hiro
Copy link

Thanks for the update @Nesopie, everything looks better now.

1/ In your sequence diagram, I think you need to clarify that only user is able to obtain vanity address otherwise it will raise the concern of privacy.
2/ Homomorphic addition wasn't clarified, i think it is also play an crucial role in your protocol.
3/ Adding security consideration section would help to clarify the status of the project, as you known all protocol need to be audited.
4/ There are some contents were derived from https://cryptobook.nakov.com/asymmetric-key-ciphers/ecies-public-key-encryption. Your should add references section.

@yash25198
Copy link

yash25198 commented Sep 28, 2024

  1. Provided miner is relatively random and is not spiteful the vanity public key will never be acquired by anyone else. We are also planning to implement FHE based solutions which will resolve this problem as well but the idea here is that no one expect the user will be able to calculate the private key. Zanity is a demonstration of what ECIES can be used for can be used and how it can reduce trust-less interactions between a person with computational needs and a resourceful person ,without a layer of escrow.
  2. Homomorphic Addition here meant point addition of public keys in the context of Private keys.
    3,4. Yep we will be definitely adding security considerations and references section.

@chiro-hiro
Copy link

(1) is strong, would love to see it in your proposal. Thanks and have a nice weekend 😁

@yash25198
Copy link

yash25198 commented Sep 28, 2024

  • We explored implementations of FHE and found a real absence of any performant solutions and are motivated to do it ourselves also as an other grant proposal fr!.
    • Sha256 with FHE
    • Point addition with FHE.
  • We also secured confidence in implementing this in RISC0 counterparts like SP1 for better understanding cause the miner ,a resourceful guy, is taking the computational effort.
  • We also believe people don't want their vanity address to be obscured after paying a hefty miner's fee for it .
  • Existence of such an implementation will crack open astronomical possibilities for privacy enabled bridging solutions.
  • ECIES with all the extended cryptographic library stack will be the main focus for this proposal 😇.

@Nesopie
Copy link
Contributor Author

Nesopie commented Oct 7, 2024

@chiro-hiro any update on the evaluation of this proposal?

@amiabix
Copy link
Collaborator

amiabix commented Oct 11, 2024

Thank you for submitting your project!

We’re merging your PR, and it’s now available for review by our judges. They’ll be assessing it based on the criteria provided, and we’ll reach out with any updates. Good luck!

@amiabix amiabix merged commit 0971422 into zk-bankai:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants